test: migrate stats/base/dists/erlang/mgf to ULP-based assertions - #15632
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwbNRSFvk4SqKZUY9iZBX7
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Sep 28, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
LGTM.
@Planeshifter Fairly consistently, your Claude routines are much more likely to make mistakes and necessitate PR clean-up. Not clear why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/erlang/mgftests (test.mgf.js,test.factory.js,test.native.js) from EPS-scaled tolerance checks toisAlmostSameValueULP-based assertions.ULPconstant per test, tightened to the measured minimum that passes over the full fixture set (verified deterministic over two runs;ULP - 1fails):kandlambda(both_large): 734k(large_shape): 2050lambda(large_rate): 851Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The bounds were measured against the JavaScript implementation (main and factory). The native addon could not be built in the authoring environment, so the same bounds were applied to
test.native.jswithout being run. The native implementation uses the samepowalgorithm, but please verify.eslintcould also not be run (dependency install failed), though the files passnode --check.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an automated scheduled routine.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01KwbNRSFvk4SqKZUY9iZBX7
Generated by Claude Code