Use ruff lint.extend-select to keep ruff's default rules - #836
Merged
Merged
Conversation
Pierre-Sassoulas
added
internal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 96.13% 96.31% +0.18%
==========================================
Files 55 55
Lines 2430 2442 +12
Branches 137 137
==========================================
+ Hits 2336 2352 +16
+ Misses 57 55 -2
+ Partials 37 35 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pierre-Sassoulas
force-pushed
the
ruff-extend-select
branch
from
September 29, 2026 07:27
4c55b5b to
043df6c
Compare
Ruff 0.16 enables a much larger default rule set. 'lint.select' was replacing it entirely; 'lint.extend-select' keeps the defaults and adds our own selection on top. Fix the new violations: - RUF022: sort __all__ - RUF046: drop redundant int() around math.floor() - RUF059: use _ for unused unpacked variables - PLW0127: remove self-assignment of scenario_name - TRY002: raise pytest.UsageError instead of a bare Exception for gherkin-terminal-reporter incompatibilities
Cover both pytest.UsageError paths: another terminal reporter in use, and xdist enabled.
Pierre-Sassoulas
force-pushed
the
ruff-extend-select
branch
from
September 29, 2026 07:41
043df6c to
673bddc
Compare
Pierre-Sassoulas
marked this pull request as draft
September 29, 2026 07:41
Most tox environments don't install pytest-xdist. Register a dummy 'dsession' plugin instead, which is what the check looks for.
Pierre-Sassoulas
marked this pull request as ready for review
September 29, 2026 08:01
Member
Author
|
I added a test to cover a line that was modified but not covered. |
alessio-b2c2
approved these changes
Sep 29, 2026
youtux
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff 0.16 enables a much larger default rule set. 'lint.select' was replacing it entirely; 'lint.extend-select' keeps the defaults and adds our own selection on top.
Fix the new violations:
__all__