Skip to content

chore(examples): fix broken scripts, remove dead ones, add README - #700

Merged
petercorke merged 4 commits into
petercorke:mainfrom
karkikamal098:chore/examples-rationalization
Sep 27, 2026
Merged

petercorke merged 4 commits into
petercorke:mainfrom
karkikamal098:chore/examples-rationalization

Conversation

@karkikamal098

Copy link
Copy Markdown
Contributor

Summary

Part of #677 (examples folder rationalization).

Not done here, for your call: merging near-duplicate scripts (RRMC/RRMC_swift, park/baur, mmc/swift_recording), and holistic_mm_non_holonomic.py, which needs a Frankie model with a mobile base to run again.

Related issue

Part of #677.

Checklist

  • PR title follows Conventional Commits
  • Tests pass locally: no library code changed; all examples/*.py compile
  • Added/updated tests: not applicable, examples are not under test
  • Type hints / docstrings: no library code changed
  • PR is small and focused
  • No project-specific test or data files added

karkikamal098 and others added 2 commits September 26, 2026 14:22
Part of petercorke#677 (examples folder rationalization).

- icra2021.py, mexican-wave.py: update to the current ET/Robot/xplot/
  iscollided API.
- Remove fetch_vision.py (FetchCamera gone since petercorke#545), ikine_evaluate2.py
  (ikine_min never existed), and test.py (scratch file).
- Add examples/README.md indexing every script with its required extras.
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (79b169c) to head (ce92469).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #700   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        143     143           
  Lines      14115   14115           
=====================================
  Misses     14115   14115           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petercorke

Copy link
Copy Markdown
Owner

Thank you for your interest in RTB -- nice bit of housekeeping. Confirmed icra2021.py was actually broken, not just stale (ETS as ET has no tz/Rz classmethods, so it would have raised AttributeError at that line), and that FetchCamera/ikine_min are genuinely gone from the two removed scripts. The README is a solid addition. Merging as part of #677.

@petercorke
petercorke merged commit fee6bb0 into petercorke:main Sep 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants