Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Implemented and locally verified. The late-joiner regression fails before the fix and passes afterward; Left as a draft for the batch coordinator. Recommend (Written by GPT-6) |
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
A second subscriber requesting group 0 could lose a relay's cached finished group when the newer live group's stream arrived first. TRACK_INFO churn parked the copy with no declared start, so SUBSCRIBE_START used arrival order and permanently raised the reader's floor past the older group.
Approach
Declare the earliest visible group retained by a warm copy as its start. Add a deterministic relay regression that reverses upstream stream arrival and keeps the first subscriber alive while the second joins. It reads known frame counts rather than waiting for the open live group's FIN, avoiding paused-time linger artifacts. Remove the completed quest and references.
Impact
Alternatives
Changing splice cursors or ordering all cached deliveries is unnecessary: the lost start metadata belongs to the warm copy itself.
Validation
nix develop --command just check: passed, including 4,616 tests (8 skipped), lint, docs, feature builds, and Markdown/shell checks.nix develop --command quest check: 462 documents valid.Follow-ups
No new decisions. The existing splice-edges and resume-latest quests remain separate.
(Written by GPT-6)