Conversation
Preserve the published index when upstream version metadata shrinks and reuse available version manifests during recovery. Publish recovered indexes only after missing version artifacts are present.
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Author
|
Closing at the repository owner’s request. Please disregard this proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The live
neo/v0/manifest.jsoncurrently contains only Minecraft 1.20.1 and 26.3, while NeoForge Maven metadata lists 1759 versions and olderneo/v0/versions/*.jsonfiles remain available. Previously the truncated index caused the generator to reprocess all of those installers; one failure prevented rebuilding it. This should allow the scheduled generator to recover the index without a client-side fallback. Related: #4530.Validation
rustfmt --check --edition 2024 apps/daedalus_client/src/forge.rscargo test -p daedalus_client --bin daedalus_client(5 tests passed)cargo clippy -p daedalus_client --bin daedalus_client --all-targetsCargo checks used a matching temporary workspace because the local clone was sparse; only
apps/daedalus_client/src/forge.rsis changed in this PR.