fix: assign sentence speakers by total overlap without double counting - #3733
Merged
Merged
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared CAM++ speaker assignment helper counts a newly leading segment's overlap twice and only accumulates segments for the currently leading speaker. For a 0-10 second sentence with speaker 0 at 0-4s and speaker 1 at 4-10s, the current real module returns speaker 0 despite speaker 1 covering 6 seconds.
Change
The normal caller supplies postprocessed diarization intervals. This does not add union/deduplication semantics for arbitrary overlapping or duplicate intervals.
Validation
Investigated while triaging #3727. This is an independently reproduced assignment defect, not a reproduction or resolution of that reporter's audio/UI symptoms. Keep that issue open for original audio/configuration evidence. No acoustic-accuracy, speaker-clustering or real-world streaming-quality claim.