Fix lesson loading on private GitHub Pages - #3
Merged
Merged
Conversation
Co-authored-by: jamesmontemagno <1676321+jamesmontemagno@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesmontemagno
September 16, 2026 15:59
View session
jamesmontemagno
marked this pull request as ready for review
September 16, 2026 15:59
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The relative URL logic is correct for both layouts, and the navigation tests pass.
This review doesn't count toward merge requirements.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes lesson and target-app URL resolution across private and project-path GitHub Pages deployments.
Changes:
- Adds a shared relative site-root resolver.
- Uses it for lesson Markdown and target-app URLs.
- Tests root-hosted and project-path layouts.
| File | Description |
|---|---|
docs/workshop/step.html |
Uses the shared site-root resolver. |
docs/language-navigation.js |
Adds and exports siteRootUrl. |
docs/tests/markdown-language-preprocessor.test.js |
Covers both Pages layouts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lessons returned HTTP 404 because the site root was inferred from GitHub Pages hostname conventions. Private Pages hosts the workshop at the domain root, causing Markdown requests to include an extra
/workshopsegment.Changes