svc: allow longer user and group names - #507
Merged
Merged
Conversation
Service user and group names are stored in 16-byte buffers, limiting them to 15 characters. This silently truncates longer names before getpwnam() and getgrnam(), preventing services configured with valid longer account names from starting. Increase the buffers to match the existing maximum configuration argument length. Signed-off-by: Anees Rehman <anees.rehman@atlascopco.com>
Collaborator
|
Thanks! Merged to master for the next -rc of 5.0, and to 4.x as 0448151 for the upcoming 4.18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service user and group names are currently limited to 15 characters because
they are stored in 16-byte buffers. Longer names are silently truncated before
being passed to
getpwnam()orgetgrnam(), preventing affected services fromstarting.
Increase
MAX_USER_LENtoMAX_ARG_LEN, allowing names up to 63 characters.This covers service users, primary groups, supplementary groups, and initctl
status output.