Conversation
|
Someone is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pages in different directories can display the wrong embedded file when their Markdown is identical. For example, both
/first/and/second/can contain[snippet](snippet.js ':include :type=code'), while each directory has its ownsnippet.js. Visiting the first page and then the second currently keeps displaying the first directory's code.The prerender cache is keyed only by raw Markdown, even though relative include resolution depends on the content base and current route. Include those two values in the cache key. The browser regression navigates first → second → first and checks the actual rendered code each time.
Related issue, if any:
Reproduced on develop at
d823dbe51c1b2dea4c2091e2b952ded0d1e16616; no matching open fix found.What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Validation
npm run test:e2e:chromium -- test/e2e/embed.test.js --workers=1 --reporter=line: passed.npm run test:jest -- --runInBand: 128 tests and 46 snapshots passed.npm run build,npm run lint,npm run typecheck, andgit diff --check: passed.Browser coverage: Chromium via Playwright; Firefox, WebKit, and unrelated E2E suites were not run locally.
Developed with assistance from OpenAI Codex; regression and fix validated locally.