fix(workers): skip loadTests in run() when suite is already populated - #5721
Merged
DenysKuchma merged 3 commits intoSep 29, 2026
Conversation
Worker threads call loadTests() in filterTests() before codecept.run(). A second loadTests() in run() duplicated Gherkin suites and executed each assigned test twice (regression since ESM loadTests in codeceptjs#5640). Add regression tests for JS and Gherkin worker assignments. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
DenysKuchma
approved these changes
Sep 29, 2026
Contributor
Author
|
@DenysKuchma seems like tests should be updated. Can I merge with failed pipeline or should I wait for fix? |
Collaborator
|
Hi, @danikkrapivnitskiy thanks a lot for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadTests()infilterTests()beforecodecept.run().codecept.run()callsloadTests()again, which duplicates Gherkin suites and runs each assigned scenario twice (stats.tests === 2for a single grep match).mocha.suite.total() > 0; setlazyLoadFiles(true)somocha.run()does not sync-reload.Tests
test/unit/worker_test.js: one worker + grep → expectstats.tests === 1(JS worker file).codecept.workers-gherkin.conf.js,workers-gherkin/single.feature) with the same assertion.Test plan
npx mocha test/unit/worker_test.js --grep "should run each assigned"Made with Cursor