fix(memory): start MCP server when launched through the bin symlink - #303
Open
PhucChuHoang wants to merge 2 commits into
Open
PhucChuHoang wants to merge 2 commits into
PhucChuHoang wants to merge 2 commits into
Conversation
…odeaholicguy#302) npx and global installs run the ai-devkit-memory bin symlink, so process.argv[1] is the link path while import.meta.url is the resolved file. The strict comparison never matched and the process exited without starting the server. Compare real paths via isMainModule(), returning false when argv[1] is missing or cannot be resolved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isMainModule(argv1, moduleUrl)inpackages/memory/src/entrypoint.ts, which compares the real paths ofprocess.argv[1]and the module file.src/index.tsinstead of the strictprocess.argv[1] === fileURLToPath(import.meta.url)check.npx @ai-devkit/memoryand global installs launch theai-devkit-memorybin symlink, so the old check never matched and the server exited silently. Importing the package as a library still does not start the server.Closes #302
Validation
tests/unit/entrypoint.test.tscovers: the module file itself, a bin symlink to it (fails on the old check), a different file, undefinedargv[1], and a missing path (no throw).memorypackage: tests (167), typecheck, lint and fmt:check pass; the Husky pre-commit hook (fullnx run-many -t test) passed.dist/index.jsstarted through a symlink now answers an MCPinitializerequest;import()of the built entry does not start the server.Follow-up
packages/memory-dashboard/src/standalone.ts:101uses the same pattern (import.meta.url === \file://${process.argv[1]}``), which fails through a bin symlink and for paths that need URL encoding (e.g. spaces). Left out to keep this PR scoped.🤖 Generated with Claude Code