fix(agent-manager): resolve spaced argv0 in AGENTS matchers - #300
Merged
Merged
Conversation
matchArgv0, matchArgv0Name, matchAnyToken and matchAnyBasename split the ps command line on whitespace, so an agent installed under a directory containing spaces was not recognised as argv[0] when confirming the launched PID. Resolve argv[0] with executablePath() from utils/process and scan only the remaining arguments in the any-token matchers. Arguments are still never folded into the executable path unless the combined path exists, and the filesystem is only consulted when a later token could complete a matching argv[0].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #297
Validation
Follow-up