Add workspace readme to Cargo.toml - #651
Conversation
|
That probably got introduced in #553 when I merged cargo-gpu into this workspace & repo. I'm surprised to see a failure like this, cause that PR has been merged months ago and noone ever noticed. Is your CI using nightly and maybe the newest nightly starts to fail here? Also, I'm trying to get a new rust-gpu version out asap, give me another day or so. |
|
The CI was using the v0.10.0-alpha.1 but was moved recently to the nightly (which is when the failure was introduced). |
|
The weird thing is, $ cargo +nightly --version EDIT: I don't mind just merging this, I just would like to know if it actually solves your issue. |
Thanks; I think this would probably be beneficial to avoid using a git commit (the previous release didn't work with the latest glam version so we chose to temporarily use a git commit).
Yes it is quite weird; the shader builds work fine in graphite outside of the nix runner. It doesn't appear to matter which version of nightly is pinned (I changed it to fix a later build error). I think perhaps it is some property of nix where it tries to parses all the crates? I have tested locally and can confirm that this patch does fix the issue. Thanks for your help reviewing. |
|
Can also confirm this works. And the Nix build fails because crane (nix build helper for rust) inlines workspace attributes and is more strict about resolution that than cargo. Will also file this with crane. EDIT: with this included builds successful again see https://github.com/GraphiteEditor/Graphite/actions/runs/36468782474/job/109085455481 |
389dfe7 to
ac663de
Compare
|
I changed it so it's no longer inheriting the readme property, but the two crates using it just define it themselves. Inheriting this properly is weird since it's a path that's always relative to the crate's @0HyperCube I see there's another branch called |
That is indeed rather strange behaviour.
This is indeed just a test and can be ignored. The graphite build now works fine with this branch. |
| description = "Install rust-gpu and it's required toolchain automatically" | ||
| repository.workspace = true | ||
| readme.workspace = true | ||
| readme = "README.md" |
There was a problem hiding this comment.
This is the default value, just remove it. There is even a lint for this (probably in pendantic set).
Some of the crates use
readme.workspace = truebut there is no readme set in the workspace manifest.This PR corrects this by adding the readme to the workspace.
This may be the cause of the error in the graphite build. In any case it is probably good to clean it up.