Conversation
MeshValue.toJSON passed the quantity through Number, so 9007199254740993 lovelace became 9007199254740992.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MeshValue.toJSONsummed asset quantities withNumber. A JS number cannot hold every lovelace amount.9007199254740993lovelace (about 9 billion ADA, under the 45 billion supply) came back as9007199254740992.Quantities are now summed as
bigint. A value that still fits in a JS number stays a number, so existing JSON output is unchanged. A value that does not fit is passed tointeger()as abigint.Test plan
toJSONof lovelace9007199254740993returned the number9007199254740992.9007199254740993, and1000000lovelace is still the number1000000.npm testin@meshsdk/commonwas not run here. The new case is intest/data/value/convertor.test.ts.Made with Cursor