fix(cleanup): clarify legacy file deletion warning - #2004
Conversation
Adapt #1820 to current cleanup behavior and docs-lab; cover directory, file, and marker-only summaries. Co-authored-by: 胥寅 <xuuyin@dingtalk.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: Fission-AI/OpenSpec/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No PR-relevant drift confirmed.
|
alfred-openspec
left a comment
There was a problem hiding this comment.
Reviewed the current head. The cleanup warning now accurately distinguishes files that are deleted entirely from managed command files that preserve custom content, and tests cover the user-facing wording. Hosted CI is green. Approved. Final review of the docs-lab change still belongs to @TabishB.
Adapt Fission-AI#1820 to current cleanup behavior and docs-lab; cover directory, file, and marker-only summaries. Co-authored-by: 胥寅 <xuuyin@dingtalk.com> (cherry picked from commit d4e1c77)
…I#1997-Fission-AI#2005 and issues Fission-AI#2000/Fission-AI#2006 Also replace owner-specific wording with neutral terms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Status
LGTM for the scoped warning fix. Ready for review.
What was wrong
Legacy cleanup said “No user content to preserve,” although
openspec/AGENTS.mdis detected by existence alone and deleted entirely.How it was fixed
Warn about whole-file deletion and ask users to back up custom content. Add warning coverage for command files and directories, put the migration guidance in
docs-lab, and include a patch changeset that reflects current cleanup behavior.Replication / proof
All 109 cleanup tests pass. Restoring the old warning fails 3 regression tests. Build, lint, TypeScript, changeset validation, and diff checks pass.
The full local suite passed 5,935 tests, with 4 existing failures reproduced on clean
mainat79b6aa9c. GitHub's Linux, macOS, and Windows test jobs all pass, along with lint, type checking, release tracking, dependency review, audit, and CodeQL.Credit
This carries forward the fix proposed by @philo-x in #1820. Thank you for identifying the misleading cleanup text, implementing the original correction, adding regression coverage, and following up with the changeset. The implementation commit retains co-author credit.
Notes
This version adapts #1820 to current
mainand moves the documentation change todocs-lab. Cleanup behavior and--forcesemantics are unchanged.Closes #1819.
Supersedes #1820.