Skip to content

Add a warning icon to Math node expressions with errors as tooltips - #4614

Merged
Keavon merged 5 commits into
masterfrom
math-expression-warning-icon
Sep 27, 2026
Merged

Keavon merged 5 commits into
masterfrom
math-expression-warning-icon

Conversation

@Keavon

@Keavon Keavon commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Partly closes #2026

image

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread website/content/features.md

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread frontend/src/components/widgets/labels/TextLabel.svelte
Comment thread frontend/src/components/floating-menus/Tooltip.svelte
@Keavon
Keavon force-pushed the math-expression-warning-icon branch from 2c871ff to 5d9a9a9 Compare September 27, 2026 09:00
@Keavon
Keavon merged commit ae321b3 into master Sep 27, 2026
12 checks passed
@Keavon
Keavon deleted the math-expression-warning-icon branch September 27, 2026 09:13
@0HyperCube

Copy link
Copy Markdown
Contributor

This fails to catch common areas such as typing xi into the f(x) node. A user might expect this to evaluate as x * i but instead the output is set to zero and there is no visible indicator in the UI.

@Keavon

Keavon commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

Correct, that is a known limitation as of this version, because it only reports parse-time errors and does not consider host-supplied bindings that can change on each execution. That'll be fixed in upcoming PRs. Also the fact that it returns 0 is currently the fallback being used as a stopgap until the async refactor is completed, at which point we can propagate an error. Thanks for testing this out and being a second pair of eyes!

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 5d9a9a9d Deployed Sep 27, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue: Math expression parser/calculator

2 participants